Skip to content

Update Appium detection#14010

Merged
christian-bromann merged 3 commits intomainfrom
ws/optimise-appium-detection
Dec 23, 2024
Merged

Update Appium detection#14010
christian-bromann merged 3 commits intomainfrom
ws/optimise-appium-detection

Conversation

@wswebcreation
Copy link
Member

@wswebcreation wswebcreation commented Dec 23, 2024 •
edited
Loading

Proposed changes

This PR optimises the Appium detection by:

  • feat: add LT support for isAppiumCapability
    • fix typings
    • add new LT caps
    • add UT's
  • feat: add LT support for getNativeContext
    • add UTs

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@wswebcreation
feat: add LT support for isAppiumCapability
4746d3d 
- fix typings
- add new LT caps
- add UT's
@wswebcreation wswebcreation added the PR: Polish 💅 PRs that contain improvements on existing features label Dec 23, 2024
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 23, 2024 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14010

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14010

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14010

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14010

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14010

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14010

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14010

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14010

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14010

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14010

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14010

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14010

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14010

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14010

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14010

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14010

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14010

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14010

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14010

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14010

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14010

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14010

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14010

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14010

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14010

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14010

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14010

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14010

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14010

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14010

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14010

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14010

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14010

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14010

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14010

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14010

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14010

commit: 204232a

christian-bromann
christian-bromann approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit e634571 into main Dec 23, 2024
@christian-bromann christian-bromann deleted the ws/optimise-appium-detection branch December 23, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wswebcreation @christian-bromann