Skip to content

catch failures onAfterCommand #13993

Merged
christian-bromann merged 1 commit intowebdriverio:v8from
harsha509:v8
Dec 18, 2024
Merged

catch failures onAfterCommand #13993
christian-bromann merged 1 commit intowebdriverio:v8from
harsha509:v8

Conversation

@harsha509
Copy link
Member

@harsha509 harsha509 commented Dec 18, 2024

fixes #13468

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@harsha509
Copy link
Member Author

This is the same fix for V8 from v9 branch. Issue is reproducible only in v8 branch!

@harsha509 harsha509 added the v8 Issues related to v8 of WebdriverIO label Dec 18, 2024
@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Dec 18, 2024
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes v8 Issues related to v8 of WebdriverIO

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants