fix(@wdio/utils): Unset geckodriver when stable is set as browserVersion by nextlevelbeard · Pull Request #13983 · webdriverio/webdriverio

nextlevelbeard · 2024-12-16T01:32:47Z

Proposed changes

Fixes a crucial bug when downloading Firefox browser for testing:

DEBUG @wdio/cli:utils: Finished to run "onPrepare" hook in 624ms
INFO @wdio/utils: Setting up browser driver for: chrome@stable - firefox@stable
INFO @wdio/utils: Setting up browser binaries for: chrome@stable - firefox@stable
INFO geckodriver: Downloading Geckodriver from https://github.com/mozilla/geckodriver/releases/download/vstable/geckodriver-vstable-linux64.tar.gz
INFO webdriver: Downloading Chromedriver v131.0.6778.108
INFO webdriver: Setting up firefox vstable_133.0.3
INFO webdriver: Setting up chrome v131.0.6778.108
INFO @wdio/local-runner: Shutting down spawned worker
INFO @wdio/local-runner: Waiting for 0 to shut down gracefully

Recently, @puppeteer/browsers was upgraded to allow to download Firefox on the stable channel, on top of the nightly/latest channel.

That means webdriverIO users can now set the capability

{
  "browserName": "firefox",
  "browserVersion": "stable"
}

to test the current latest stable release of Firefox.

But @wdio/utils package was only checking for "latest" browserVersion to get the correct geckodriver URL to download, it now also needs to check for stable. In the future, more channels will become available, therefore a firefoxChannels array was set, that includes the new stable channel.

Geckodriver now downloads successfully when browserVersion is set to "stable" .

Types of changes

Polish (an improvement for an existing feature)
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (improvements to the project's docs)
Specification changes (updates to WebDriver command specifications)
Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation (if appropriate)
I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

This change is solely for v9 and doesn't need to be back-ported
Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

pkg-pr-new · 2024-12-16T01:35:47Z

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@13983

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@13983

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@13983

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@13983

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@13983

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@13983

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@13983

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@13983

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@13983

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@13983

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@13983

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@13983

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@13983

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@13983

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@13983

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@13983

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@13983

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@13983

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@13983

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@13983

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@13983

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@13983

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@13983

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@13983

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@13983

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@13983

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@13983

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@13983

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@13983

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@13983

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@13983

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@13983

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@13983

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@13983

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@13983

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@13983

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@13983

commit: fdab700

christian-bromann

LGTM 👍

packages/wdio-utils/src/node/manager.ts

wdio-bot · 2024-12-16T16:19:14Z

Hey nextlevelbeard 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
⚠️ You seemed to have committed using an email address ending up with @users.noreply.github.com, if you don't receive the email please feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

fix(@wdio/utils): unset geckodriver when stable is set as browserVersion

131f353

nextlevelbeard requested a review from christian-bromann December 16, 2024 01:34

christian-bromann approved these changes Dec 16, 2024

View reviewed changes

packages/wdio-utils/src/node/manager.ts Outdated Show resolved Hide resolved

Update packages/wdio-utils/src/node/manager.ts

fdab700

christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Dec 16, 2024

christian-bromann merged commit 21f620b into webdriverio:main Dec 16, 2024

wdio-bot added the Expensable $15 💸 label Dec 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(@wdio/utils): Unset geckodriver when stable is set as browserVersion#13983

fix(@wdio/utils): Unset geckodriver when stable is set as browserVersion#13983
christian-bromann merged 2 commits intowebdriverio:mainfrom
nextlevelbeard:fix/geckodriver-version

nextlevelbeard commented Dec 16, 2024 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Dec 16, 2024 •

edited

Loading

Uh oh!

christian-bromann left a comment

Uh oh!

Uh oh!

wdio-bot commented Dec 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nextlevelbeard commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Types of changes

Checklist

Backport Request

Further comments

Reviewers: @webdriverio/project-committers

Uh oh!

pkg-pr-new bot commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christian-bromann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wdio-bot commented Dec 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nextlevelbeard commented Dec 16, 2024 •

edited

Loading

pkg-pr-new bot commented Dec 16, 2024 •

edited

Loading