Skip to content

Remove unused cli-spinners dependency#13963

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
alexparish:remove-unused-wdio-cli-dependencies
Dec 11, 2024
Merged

Remove unused cli-spinners dependency#13963
christian-bromann merged 1 commit intowebdriverio:mainfrom
alexparish:remove-unused-wdio-cli-dependencies

Conversation

@alexparish
Copy link
Contributor

@alexparish alexparish commented Dec 9, 2024 •
edited
Loading

Proposed changes

The @wdio/cli package has a dependencies on cli-spinners and tsx however there are no references to these packages in the code. This PR removes the dependencies.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 9, 2024 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@13963

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@13963

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@13963

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@13963

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@13963

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@13963

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@13963

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@13963

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@13963

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@13963

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@13963

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@13963

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@13963

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@13963

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@13963

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@13963

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@13963

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@13963

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@13963

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@13963

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@13963

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@13963

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@13963

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@13963

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@13963

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@13963

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@13963

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@13963

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@13963

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@13963

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@13963

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@13963

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@13963

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@13963

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@13963

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@13963

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@13963

commit: b2b63f7

christian-bromann
christian-bromann requested changes Dec 10, 2024
View reviewed changes
@alexparish alexparish force-pushed the remove-unused-wdio-cli-dependencies branch from 0b162b8 to b2b63f7 Compare December 11, 2024 16:28
@alexparish alexparish changed the title Remove unused cli-spinners and tsx dependencies Remove unused cli-spinners dependency Dec 11, 2024
christian-bromann
christian-bromann approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Dec 11, 2024
@christian-bromann christian-bromann merged commit 03b401a into webdriverio:main Dec 11, 2024
@wdio-bot
Copy link
Contributor

wdio-bot commented Dec 11, 2024

Hey alexparish 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $15 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexparish @wdio-bot @christian-bromann