Skip to content

fix(webdriverio): support opening file urls#13960

Merged
christian-bromann merged 5 commits intomainfrom
cb/fix-resource-protocol
Dec 9, 2024
Merged

fix(webdriverio): support opening file urls#13960
christian-bromann merged 5 commits intomainfrom
cb/fix-resource-protocol

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Dec 9, 2024

Proposed changes

fixes #13956

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

n/a

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 9, 2024 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@13960

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@13960

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@13960

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@13960

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@13960

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@13960

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@13960

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@13960

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@13960

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@13960

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@13960

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@13960

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@13960

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@13960

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@13960

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@13960

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@13960

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@13960

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@13960

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@13960

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@13960

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@13960

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@13960

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@13960

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@13960

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@13960

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@13960

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@13960

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@13960

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@13960

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@13960

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@13960

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@13960

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@13960

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@13960

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@13960

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@13960

commit: b8c2c26

Delta456
Delta456 reviewed Dec 9, 2024
View reviewed changes
@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Dec 9, 2024
damencho
damencho reviewed Dec 9, 2024
View reviewed changes
packages/webdriverio/src/networkManager.ts
* ignore urls that users wouldn't navigate to
*/
!log.url.startsWith('http')
!SUPPORTED_NAVIGATION_PROTOCOLS.some((protocol) => log.url.startsWith(protocol))
Copy link
Contributor

@damencho damencho Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@christian-bromann christian-bromann merged commit 05e280b into main Dec 9, 2024
@christian-bromann christian-bromann deleted the cb/fix-resource-protocol branch December 9, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@damencho damencho damencho left review comments

@Delta456 Delta456 Delta456 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Timeout when opening url 'file://'

3 participants

@christian-bromann @damencho @Delta456