fix(@wdio/runner): Continue emitting event on the runner even when a reporter throws an error#13958
Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom Dec 9, 2024
Conversation
eslint-plugin-wdio
@wdio/appium-service
@wdio/allure-reporter
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/logger
@wdio/local-runner
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
Contributor
|
Hey dprevost-LMI 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
3 tasks
Contributor
|
Hey dprevost-LMI 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
In this issue, we discovered we could hang the runner process when processing the reporters with specific conditions. Moreover, after a closer look, when the AllureReporter throws an error, it fails the run, stating that some tests failed when this is not the case. Finally, since we can configure multiple reporters, an error thrown by one should not affect the other reporters.
So, to have more robust test runs and make a better effort at finishing reporting, I propose to try-catch the error after emitting the event to a faulty reporter, output the error in the console, continue to the next reporter, and emit the next event.
Types of changes
Checklist
Backport Request
v9and doesn't need to be back-portedFurther comments
Here is an example where the Allure reporter was throwing an error, but the Spec reporter was not. With the fix, we can now see that the run was successful, but Allure has potential problems due to the error. Weirdly, the second picture shows that the Allure reporting was still working despite the error.
Reviewers: @webdriverio/project-committers