fix(@wdio/runner): Respect excludes in capabilities in multiremote case. by damencho · Pull Request #13878 · webdriverio/webdriverio

damencho · 2024-11-12T20:41:47Z

When a spec is excluded from some capability there is no point of starting the browser session for it.

Proposed changes

When spec is excluded in multiremote the browser sessions are still created for it.

specs: [
        'test/example.spec.ts'
    ],

    capabilities: {
        participant1: {
            capabilities: {
                browserName: 'chrome'
            }
        },
        participant2: {
            capabilities: {
                browserName: 'chrome',
                'wdio:exclude': [
                    'test/example.spec.ts'
                ]
            }
        }
    },

This will create two browser sessions for the test and the PR will change that to be only one.

Types of changes

Polish (an improvement for an existing feature)
[ X ] Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (improvements to the project's docs)
Specification changes (updates to WebDriver command specifications)
Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

[ X ] I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
[ X ] I have added the necessary documentation (if appropriate)
[ X ] I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

[ X ] This change is solely for v9 and doesn't need to be back-ported
Back-ported PR at #XXXXX

Further comments

It was discussed in #13875

Reviewers: @webdriverio/project-committers

Fixes webdriverio#13875. When a spec is excluded from some capability there is no point of starting the browser session for it.

linux-foundation-easycla · 2024-11-12T20:41:51Z

The committers listed above are authorized under a signed CLA.

✅ login: christian-bromann / name: Christian Bromann (da7986f)
✅ login: damencho / name: Дамян Минков (5c9915f, b69c17c, cab6156)

pkg-pr-new · 2024-11-12T20:46:36Z

Open in Stackblitz

eslint-plugin-wdio

pnpm add https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@13878

@wdio/allure-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@13878

@wdio/browser-runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@13878

@wdio/browserstack-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@13878

@wdio/appium-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@13878

@wdio/cli

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@13878

@wdio/concise-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@13878

@wdio/config

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@13878

@wdio/cucumber-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@13878

@wdio/dot-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@13878

@wdio/firefox-profile-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@13878

@wdio/globals

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@13878

@wdio/jasmine-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@13878

@wdio/json-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@13878

@wdio/junit-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@13878

@wdio/lighthouse-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@13878

@wdio/local-runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@13878

@wdio/logger

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@13878

@wdio/mocha-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@13878

@wdio/protocols

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@13878

@wdio/repl

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@13878

@wdio/reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@13878

@wdio/runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@13878

@wdio/sauce-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@13878

@wdio/shared-store-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@13878

@wdio/smoke-test-cjs-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@13878

@wdio/smoke-test-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@13878

@wdio/smoke-test-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@13878

@wdio/spec-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@13878

@wdio/static-server-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@13878

@wdio/sumologic-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@13878

@wdio/testingbot-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@13878

@wdio/types

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@13878

@wdio/utils

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@13878

@wdio/webdriver-mock-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@13878

webdriver

pnpm add https://pkg.pr.new/webdriverio/webdriverio/webdriver@13878

webdriverio

pnpm add https://pkg.pr.new/webdriverio/webdriverio@13878

commit: da7986f

christian-bromann

Can we add some unit tests for this as well?

packages/wdio-runner/src/index.ts

christian-bromann · 2024-11-13T16:13:38Z

packages/wdio-runner/src/index.ts

            _automationProtocol: this._config.automationProtocol,
            automationProtocol: './protocol-stub.js'
-        }, caps)
+        }, filteredCaps)


Suggested change

}, filteredCaps)

}, this._caps)

packages/wdio-runner/src/index.ts

damencho · 2024-11-13T17:50:31Z

Can we add some unit tests for this as well?

Is it ok to add them in smoke tests?

christian-bromann · 2024-11-13T20:01:22Z

Is it ok to add them in smoke tests?

Yes, you should be able to verify that on x of x session were created.

damencho · 2024-11-13T21:14:57Z

Is it ok to add them in smoke tests?

Yes, you should be able to verify that on x of x session were created.

Yep, I have added the tests.

christian-bromann · 2024-11-13T22:59:42Z

Mind signing the CLA?

damencho · 2024-11-14T00:32:48Z

Mind signing the CLA?

Yes, I'm working on that with our legal team, sorry for the delay.

damencho · 2024-11-14T14:25:30Z

Mind signing the CLA?

Yes, I'm working on that with our legal team, sorry for the delay.

Signed.

christian-bromann

Just adding a little comment for understanding.

LGTM 👍

packages/wdio-runner/src/index.ts

wdio-bot · 2024-11-14T19:34:13Z

Hey damencho 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

fix(@wdio/runner): Respect excludes in capabilities in multiremote case.

b69c17c

Fixes webdriverio#13875. When a spec is excluded from some capability there is no point of starting the browser session for it.

damencho mentioned this pull request Nov 12, 2024

[🐛 Bug]: Skips creating multiremote session when that session is excluded #13875

Closed

1 task

christian-bromann requested changes Nov 13, 2024

View reviewed changes

squash: Fix comments.

cab6156

squash: Adds smoke test.

5c9915f

damencho mentioned this pull request Nov 14, 2024

feat(tests): First test from torture to meet. jitsi/jitsi-meet#15298

Merged

christian-bromann approved these changes Nov 14, 2024

View reviewed changes

packages/wdio-runner/src/index.ts Show resolved Hide resolved

Update packages/wdio-runner/src/index.ts

da7986f

christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Nov 14, 2024

christian-bromann merged commit 6d146cd into webdriverio:main Nov 14, 2024

wdio-bot added the Expensable $35 💸 label Nov 14, 2024

Uh oh!

Conversation

damencho commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Types of changes

Checklist

Backport Request

Further comments

Reviewers: @webdriverio/project-committers

Uh oh!

linux-foundation-easycla bot commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christian-bromann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

christian-bromann Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

damencho commented Nov 13, 2024

Uh oh!

christian-bromann commented Nov 13, 2024

Uh oh!

damencho commented Nov 13, 2024

Uh oh!

christian-bromann commented Nov 13, 2024

Uh oh!

damencho commented Nov 14, 2024

Uh oh!

damencho commented Nov 14, 2024

Uh oh!

christian-bromann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wdio-bot commented Nov 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

damencho commented Nov 12, 2024 •

edited

Loading

linux-foundation-easycla bot commented Nov 12, 2024 •

edited

Loading

pkg-pr-new bot commented Nov 12, 2024 •

edited

Loading