Skip to content

fix(webdriverio): null check for switchFrame#13869

Merged
christian-bromann merged 1 commit intomainfrom
cb/fix-switchFrame
Nov 8, 2024
Merged

fix(webdriverio): null check for switchFrame#13869
christian-bromann merged 1 commit intomainfrom
cb/fix-switchFrame

Conversation

@christian-bromann
Copy link
Member

Proposed changes

fixes #13868

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Nov 8, 2024
@christian-bromann christian-bromann merged commit 0736e13 into main Nov 8, 2024
@christian-bromann christian-bromann deleted the cb/fix-switchFrame branch November 8, 2024 21:49
jan-molak added a commit to serenity-js/serenity-js that referenced this pull request Nov 14, 2024
…ndling fix

WebdriverIO 9.2.12 includes webdriverio/webdriverio#13869, which fixes the switchFrame method and
allows Serenity/JS to migrate to it from the legacy switchToFrame

Related tickets: re #2572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: browser.switchFrame(null) throws TypeError in Webdriver Classic mode

1 participant