Merged
Conversation
7c5ba7e to
c574447
Compare
Member
|
It's a bit too much to review to be honest but I caught some potentional things |
| } | ||
|
|
||
| attachJSON(name: string, json: any) { | ||
| attachJSON(name: string, json: unknown) { |
Member
There was a problem hiding this comment.
I believe we can assume this is either an array or object (or a string)?
Member
Author
There was a problem hiding this comment.
We can assume that but we never know what the user passes in so unknown would be a better choice IMHO
| * @private | ||
| */ | ||
| export const isEmpty = (object: any) => | ||
| export const isEmpty = (object: unknown) => |
| // From: https://github.com/sindresorhus/has-flag/blob/main/index.js | ||
| /// function hasFlag(flag, argv = globalThis.Deno?.args ?? process.argv) { | ||
| function hasFlag(flag: string, argv = globalThis.Deno ? globalThis.Deno.args : process.argv) { | ||
| function hasFlag(flag: string, argv = process.argv) { |
Member
There was a problem hiding this comment.
The Deno check has been removed, is this intentional?
Member
Author
There was a problem hiding this comment.
Yes, the assumption is that Deno now better supports Node.js primitives. Nonetheless, we haven't made any claims to support Deno.
5c3df82 to
8303ffc
Compare
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/cli
@wdio/concise-reporter
@wdio/browserstack-service
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This patch updates this project to use Eslint v9.
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
n/a
Reviewers: @webdriverio/project-committers