Skip to content

chore(@wdio/spec-reporter): use base name of app path in prefix#13842

Merged
christian-bromann merged 1 commit intomainfrom
cb/spec-app-path
Nov 1, 2024
Merged

chore(@wdio/spec-reporter): use base name of app path in prefix#13842
christian-bromann merged 1 commit intomainfrom
cb/spec-app-path

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Nov 1, 2024

Proposed changes

The spec reporter can become unreadable if a user uses an appium:app capability with a long path to an application, e.g.:

"spec" Reporter:
------------------------------------------------------------------
[/var/folders/w2/s84ng4p93vz2mw5cdc_zkzbc0000kr/T/tmpZFqssp/ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0] Running: /var/folders/w2/s84ng4p93vz2mw5cdc_zkzbc0000kr/T/tmpZFqssp/ios.simulator.wdio.native.app.v1.0.8.zip on iOS
[/var/folders/w2/s84ng4p93vz2mw5cdc_zkzbc0000kr/T/tmpZFqssp/ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0] Session ID: c53e5adb93724bd79d5c9b538b8e4258
[/var/folders/w2/s84ng4p93vz2mw5cdc_zkzbc0000kr/T/tmpZFqssp/ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]
[/var/folders/w2/s84ng4p93vz2mw5cdc_zkzbc0000kr/T/tmpZFqssp/ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0] » /tests/integration/specs/general-spec.ts
[/var/folders/w2/s84ng4p93vz2mw5cdc_zkzbc0000kr/T/tmpZFqssp/ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0] Context
[/var/folders/w2/s84ng4p93vz2mw5cdc_zkzbc0000kr/T/tmpZFqssp/ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]    ✓ Native Context Switches correctly
[/var/folders/w2/s84ng4p93vz2mw5cdc_zkzbc0000kr/T/tmpZFqssp/ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]
[/var/folders/w2/s84ng4p93vz2mw5cdc_zkzbc0000kr/T/tmpZFqssp/ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]       .........Pending Reasons.........
[/var/folders/w2/s84ng4p93vz2mw5cdc_zkzbc0000kr/T/tmpZFqssp/ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]          Temporarily disabled with xit
[/var/folders/w2/s84ng4p93vz2mw5cdc_zkzbc0000kr/T/tmpZFqssp/ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]    ✓ Webview Context Switches correctly

We should just use the file name:

"spec" Reporter:
------------------------------------------------------------------
[ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0] Running: ios.simulator.wdio.native.app.v1.0.8.zip on iOS
[ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0] Session ID: c53e5adb93724bd79d5c9b538b8e4258
[ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]
[ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0] » /tests/integration/specs/general-spec.ts
[ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0] Context
[ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]    ✓ Native Context Switches correctly
[ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]
[ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]       .........Pending Reasons.........
[ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]          Temporarily disabled with xit
[ios.simulator.wdio.native.app.v1.0.8.zip iOS #0-0]    ✓ Webview Context Switches correctly

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Nov 1, 2024
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 1, 2024

Open in Stackblitz

eslint-plugin-wdio

pnpm add https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@13842

@wdio/allure-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@13842

@wdio/browser-runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@13842

@wdio/browserstack-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@13842

@wdio/appium-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@13842

@wdio/cli

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@13842

@wdio/concise-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@13842

@wdio/config

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@13842

@wdio/cucumber-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@13842

@wdio/dot-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@13842

@wdio/firefox-profile-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@13842

@wdio/globals

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@13842

@wdio/jasmine-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@13842

@wdio/json-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@13842

@wdio/junit-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@13842

@wdio/lighthouse-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@13842

@wdio/local-runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@13842

@wdio/logger

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@13842

@wdio/mocha-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@13842

@wdio/protocols

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@13842

@wdio/repl

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@13842

@wdio/reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@13842

@wdio/runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@13842

@wdio/sauce-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@13842

@wdio/shared-store-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@13842

@wdio/smoke-test-cjs-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@13842

@wdio/smoke-test-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@13842

@wdio/smoke-test-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@13842

@wdio/spec-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@13842

@wdio/static-server-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@13842

@wdio/sumologic-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@13842

@wdio/testingbot-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@13842

@wdio/types

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@13842

@wdio/utils

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@13842

@wdio/webdriver-mock-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@13842

webdriver

pnpm add https://pkg.pr.new/webdriverio/webdriverio/webdriver@13842

webdriverio

pnpm add https://pkg.pr.new/webdriverio/webdriverio@13842

commit: 59f54ed

@christian-bromann christian-bromann merged commit f3b6538 into main Nov 1, 2024
@christian-bromann christian-bromann deleted the cb/spec-app-path branch November 1, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@christian-bromann