fix(webdriverio): improve switchFrame behavior by christian-bromann · Pull Request #13781 · webdriverio/webdriverio

christian-bromann · 2024-10-19T20:16:49Z

Proposed changes

Types of changes

Polish (an improvement for an existing feature)
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (improvements to the project's docs)
Specification changes (updates to WebDriver command specifications)
Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation (if appropriate)
I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

This change is solely for v9 and doesn't need to be back-ported
Back-ported PR at #XXXXX

Further comments

n/a

Reviewers: @webdriverio/project-committers

pkg-pr-new · 2024-10-19T20:43:02Z

Open in Stackblitz

eslint-plugin-wdio

pnpm add https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@13781

@wdio/allure-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@13781

@wdio/browser-runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@13781

@wdio/browserstack-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@13781

@wdio/appium-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@13781

@wdio/cli

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@13781

@wdio/concise-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@13781

@wdio/config

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@13781

@wdio/cucumber-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@13781

@wdio/dot-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@13781

@wdio/firefox-profile-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@13781

@wdio/globals

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@13781

@wdio/jasmine-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@13781

@wdio/json-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@13781

@wdio/junit-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@13781

@wdio/lighthouse-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@13781

@wdio/local-runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@13781

@wdio/logger

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@13781

@wdio/mocha-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@13781

@wdio/repl

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@13781

@wdio/protocols

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@13781

@wdio/reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@13781

@wdio/runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@13781

@wdio/sauce-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@13781

@wdio/shared-store-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@13781

@wdio/smoke-test-cjs-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@13781

@wdio/smoke-test-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@13781

@wdio/smoke-test-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@13781

@wdio/static-server-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@13781

@wdio/spec-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@13781

@wdio/sumologic-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@13781

@wdio/testingbot-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@13781

@wdio/types

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@13781

@wdio/utils

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@13781

@wdio/webdriver-mock-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@13781

webdriver

pnpm add https://pkg.pr.new/webdriverio/webdriverio/webdriver@13781

webdriverio

pnpm add https://pkg.pr.new/webdriverio/webdriverio@13781

commit: 5de1736

packages/webdriverio/src/commands/browser/switchFrame.ts

torokati44 · 2024-10-27T10:06:00Z

Does this also fix #13763 perhaps? 🤔

christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 19, 2024

christian-bromann force-pushed the cb/switch-frame-improvements branch from 0e2f3d5 to 430036b Compare October 19, 2024 20:40

christian-bromann mentioned this pull request Oct 19, 2024

fix(@wdio/browser-runner): publish Mocha assets as part of package #13782

Merged

13 tasks

danielhjacobs reviewed Oct 20, 2024

View reviewed changes

packages/webdriverio/src/commands/browser/switchFrame.ts Outdated Show resolved Hide resolved

christian-bromann added 3 commits October 26, 2024 09:37

fix(webdriverio): improve switchFrame behavior

1e15168

progress

abc83f2

fix tests

4ca28a6

christian-bromann force-pushed the cb/switch-frame-improvements branch from 6d5a2cf to 4ca28a6 Compare October 26, 2024 16:53

christian-bromann added 6 commits October 26, 2024 10:38

resolve race conditions

7cbdf86

fix unit test

4ce4067

Merge branch 'main' into cb/switch-frame-improvements

6845783

Merge branch 'main' into cb/switch-frame-improvements

b1e7a0d

minor tweak

77db2eb

minor tweaks to test

5de1736

christian-bromann merged commit 943a698 into main Oct 27, 2024

christian-bromann deleted the cb/switch-frame-improvements branch October 27, 2024 02:25

torokati44 mentioned this pull request Oct 28, 2024

[🐛 Bug]: WDIO v9.2.1 : Actions such as "click()" no longer work after switching to a frame (see "switchFrame(<context>)") #13763

Closed

3 tasks

danielhjacobs mentioned this pull request Oct 28, 2024

[🐛 Bug]: Certain element methods (isExisting, getText) don't work in browser.switchFrame, others don't work in browser.switchToFrame #13808

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(webdriverio): improve switchFrame behavior#13781

fix(webdriverio): improve switchFrame behavior#13781
christian-bromann merged 9 commits intomainfrom
cb/switch-frame-improvements

christian-bromann commented Oct 19, 2024

Uh oh!

pkg-pr-new bot commented Oct 19, 2024 •

edited

Loading

Uh oh!

Uh oh!

torokati44 commented Oct 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

christian-bromann commented Oct 19, 2024

Proposed changes

Types of changes

Checklist

Backport Request

Further comments

Reviewers: @webdriverio/project-committers

Uh oh!

pkg-pr-new bot commented Oct 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

torokati44 commented Oct 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pkg-pr-new bot commented Oct 19, 2024 •

edited

Loading