Skip to content

Remove unused gaze dependency#13756

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
alexparish:remove-unused-gaze-dependency
Oct 11, 2024
Merged

Remove unused gaze dependency#13756
christian-bromann merged 1 commit intowebdriverio:mainfrom
alexparish:remove-unused-gaze-dependency

Conversation

@alexparish
Copy link
Contributor

@alexparish alexparish commented Oct 11, 2024 •
edited
Loading

Proposed changes

The @wdio/runner package has a dependency on gaze however there are no references to this package in the code. This PR removes the dependency.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 11, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: alexparish / name: Alex Parish (d51d37b)

@alexparish alexparish force-pushed the remove-unused-gaze-dependency branch 4 times, most recently from 0bc2c53 to 1e7a3c1 Compare October 11, 2024 20:31
@alexparish alexparish force-pushed the remove-unused-gaze-dependency branch from 1e7a3c1 to d51d37b Compare October 11, 2024 20:40
christian-bromann
christian-bromann approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow .. this one has been unused for 7 years 🙈 good catch 👌

@christian-bromann christian-bromann added the PR: Internal 🏠 PRs that contain changes internals label Oct 11, 2024
@christian-bromann christian-bromann merged commit eeab550 into webdriverio:main Oct 11, 2024
@alexparish alexparish deleted the remove-unused-gaze-dependency branch October 11, 2024 22:40
@wdio-bot
Copy link
Contributor

wdio-bot commented Oct 12, 2024

Hey alexparish 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $15 💸 PR: Internal 🏠 PRs that contain changes internals

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexparish @wdio-bot @christian-bromann