fix(webdriverio): make command more compatible with v8 behavior#13746
Merged
christian-bromann merged 7 commits intomainfrom Oct 8, 2024
Merged
fix(webdriverio): make command more compatible with v8 behavior#13746christian-bromann merged 7 commits intomainfrom
christian-bromann merged 7 commits intomainfrom
Conversation
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browserstack-service
@wdio/browser-runner
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/protocols
@wdio/mocha-framework
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/spec-reporter
@wdio/smoke-test-service
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
Member
Author
|
This patch ended up having a bunch more fixed than original planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This got reported on Discord: a user wanted to inject a script before the page is fully loaded and was using the WebDriver Classic
pageLoadStrategy: 'none'to achieve this. With v9 we completely ignore this capability as we do page loads with Bidi. This patch will fixes this behavior.We also had an issue with our
urldocs given that we moved the interface documentation above the command so our docs generation process mistakenly used it as command docs.Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers