Skip to content

fix(webdriverio): remove default params in actions#13730

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
lacell75:fixPointer
Oct 8, 2024
Merged

fix(webdriverio): remove default params in actions#13730
christian-bromann merged 2 commits intowebdriverio:mainfrom
lacell75:fixPointer

Conversation

@lacell75
Copy link
Contributor

@lacell75 lacell75 commented Oct 2, 2024

Proposed changes

All parameters in action command are sent even when its value is 0. This is a problem for winappdriver
This fix removes these unnecessary parameters.

2024-10-01T09:39:49.859Z INFO webdriver: COMMAND performActions(<object>)
[0-0] 2024-10-01T09:39:49.862Z INFO webdriver: [POST]
http://172.30.0.31:4444/wd/hub/session/5aacf671-032a-41ae-a126-386b6dc16860/actions
[0-0] 2024-10-01T09:39:49.863Z INFO webdriver: DATA {
[0-0]   actions: [
[0-0]     {
[0-0]       id: 'action1',
[0-0]       type: 'pointer',
[0-0]       parameters: [Object],
[0-0]       actions: [Array]
[0-0]     }
[0-0]   ]
[0-0] }
[0-0] 2024-10-01T09:39:49.950Z DEBUG webdriver: request failed due to response error: invalid argument
[0-0] 2024-10-01T09:39:49.950Z WARN webdriver: Request failed with status 400 due to "width" attribute is not a floating point value greater or equal to 1

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 2, 2024 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

pnpm add https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@13730

@wdio/allure-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@13730

@wdio/browser-runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@13730

@wdio/appium-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@13730

@wdio/browserstack-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@13730

@wdio/cli

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@13730

@wdio/config

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@13730

@wdio/concise-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@13730

@wdio/dot-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@13730

@wdio/firefox-profile-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@13730

@wdio/cucumber-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@13730

@wdio/jasmine-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@13730

@wdio/globals

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@13730

@wdio/json-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@13730

@wdio/junit-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@13730

@wdio/lighthouse-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@13730

@wdio/local-runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@13730

@wdio/logger

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@13730

@wdio/mocha-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@13730

@wdio/protocols

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@13730

@wdio/repl

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@13730

@wdio/reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@13730

@wdio/runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@13730

@wdio/shared-store-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@13730

@wdio/sauce-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@13730

@wdio/smoke-test-cjs-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@13730

@wdio/smoke-test-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@13730

@wdio/smoke-test-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@13730

@wdio/spec-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@13730

@wdio/sumologic-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@13730

@wdio/static-server-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@13730

@wdio/types

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@13730

@wdio/utils

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@13730

@wdio/testingbot-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@13730

webdriver

pnpm add https://pkg.pr.new/webdriverio/webdriverio/webdriver@13730

@wdio/webdriver-mock-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@13730

webdriverio

pnpm add https://pkg.pr.new/webdriverio/webdriverio@13730

commit: 4f88a4d

@lacell75 lacell75 closed this Oct 2, 2024
@lacell75 lacell75 reopened this Oct 2, 2024
@lacell75 lacell75 changed the title fix: remove default params in actions fix(webdriverio):: remove default params in actions Oct 2, 2024
@lacell75 lacell75 changed the title fix(webdriverio):: remove default params in actions fix(webdriverio): remove default params in actions Oct 2, 2024
christian-bromann
christian-bromann approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Let me take a look at the failing Ubuntu component tests before we move on.

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 2, 2024
@lacell75 lacell75 mentioned this pull request Oct 2, 2024
Merged
13 tasks
@christian-bromann christian-bromann merged commit 7c378e3 into webdriverio:main Oct 8, 2024
@wdio-bot
Copy link
Contributor

wdio-bot commented Oct 8, 2024

Hey lacell75 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lacell75 @wdio-bot @christian-bromann