Skip to content

Added information on typescript types for wdio-shared-store-service#13514

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
sauterl:patch-1
Sep 5, 2024
Merged

Added information on typescript types for wdio-shared-store-service#13514
christian-bromann merged 1 commit intowebdriverio:mainfrom
sauterl:patch-1

Conversation

@sauterl
Copy link
Contributor

@sauterl sauterl commented Sep 4, 2024 •
edited
Loading

Proposed changes

Adds a missing configuration step to the shared-store service documentation page.
Solution source is: Source: #5815 (comment)

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 4, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@sauterl
Copy link
Contributor Author

sauterl commented Sep 4, 2024

Since this is a very small documentation update, I am not sure how I am supposed to test this?

Anyways, thanks for the great work with wdio!

@christian-bromann
Copy link
Member

christian-bromann commented Sep 4, 2024

Thanks for the contribution, mind signing the CLA?

christian-bromann
christian-bromann approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Sep 5, 2024
@christian-bromann christian-bromann merged commit 9ec608f into webdriverio:main Sep 5, 2024
@wdio-bot
Copy link
Contributor

wdio-bot commented Sep 5, 2024

Hey sauterl 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
⚠️ You seemed to have committed using an email address ending up with @users.noreply.github.com, if you don't receive the email please feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $15 💸 PR: Docs 📝 PRs that contain changes to the documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sauterl @christian-bromann @wdio-bot