Fix addInitScript example in v9 blog post#13486
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Sep 1, 2024
Merged
Fix addInitScript example in v9 blog post#13486christian-bromann merged 1 commit intowebdriverio:mainfrom
addInitScript example in v9 blog post#13486christian-bromann merged 1 commit intowebdriverio:mainfrom
Conversation
In the blogpost announcing Webdriverio v9, the `addInitScript()` example shows a function that takes `callback` as a parameter, but then calls `emit` instead (after looking at the docs, this is clearly supposed to be the parameter named `callback`). I changed the name of the parameter to `emit` to match the examples in the actual docs, although which name to use is pretty arbitrary.
Contributor
|
Hey Mr0grog 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the blogpost announcing Webdriverio v9, the
addInitScript()example shows a function that takescallbackas a parameter, but then callsemitinstead (after looking at the docs, this is clearly intending to call the parameter namedcallback). I changed the name of the parameter toemitto match the examples in the docs, although which name to use is pretty arbitrary.Types of changes
Checklist
Backport Request
v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers