Skip to content

feat(webdriverio): implement auto waiting for element to become inter…#13371

Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom
erwinheitzman:auto-wait-for-element-interactable
Aug 15, 2024
Merged

feat(webdriverio): implement auto waiting for element to become inter…#13371
christian-bromann merged 3 commits intowebdriverio:mainfrom
erwinheitzman:auto-wait-for-element-interactable

Conversation

@erwinheitzman
Copy link
Member

Implement auto-waiting for elements to become interactable (only happens when the element isn't interactable).

How it works:

if the element will not become interactable within the time set by the waitforTimeout, it will throw the expected error message with html to notify the user which element did not become interactable.
if the element does become interactable within the time set by the waitforTimeout, it will continue the tests without errors

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@christian-bromann christian-bromann merged commit b188276 into webdriverio:main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants