Skip to content

fix(@wdio/utils): Don't download chromedriver with CHROMEDRIVER_PATH (v8 backport)#13208

Merged
christian-bromann merged 1 commit intowebdriverio:v8from
johnp:backport-pr-13207
Jul 22, 2024
Merged

fix(@wdio/utils): Don't download chromedriver with CHROMEDRIVER_PATH (v8 backport)#13208
christian-bromann merged 1 commit intowebdriverio:v8from
johnp:backport-pr-13207

Conversation

@johnp
Copy link
Copy Markdown
Contributor

@johnp johnp commented Jul 22, 2024

Proposed changes

Fixes #12933. Note that the bug here was simply downloading Chromedriver needlessly. We did already end up using the chromedriver from CHROMEDRIVER_PATH (verified via strace -f -e trace=process wdio run wdio.conf.js).

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

… set

and the browser is in fact chrome/chromium.
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants