fix-v8(@wdio/appium-service): add port to appium start command#13179
Merged
christian-bromann merged 3 commits intowebdriverio:v8from Jul 24, 2024
Merged
Conversation
13 tasks
Member
|
@vparlah mind signing the CLA? Also it would be nice to harden this capability by having a proper unit test for this. |
f057b4f to
8f6fb5a
Compare
Contributor
Author
|
It doesn't seem like the failures are related to the changes in this PR, does it? |
Member
|
Nope they don't, we can ignore them. |
christian-bromann
approved these changes
Jul 24, 2024
Member
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix for this PR: (@wdio/appium-service): make Appium start on a random port #11757. The port value wasn't added in the appium start command. So, no matter what random port was chosen, appium always tries to start it on default, even if it's busy
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers