Skip to content

fix-v8(@wdio/appium-service): add port to appium start command#13179

Merged
christian-bromann merged 3 commits intowebdriverio:v8from
vparlah:appium-service/fix-random-port-v8
Jul 24, 2024
Merged

fix-v8(@wdio/appium-service): add port to appium start command#13179
christian-bromann merged 3 commits intowebdriverio:v8from
vparlah:appium-service/fix-random-port-v8

Conversation

@vparlah
Copy link
Copy Markdown
Contributor

@vparlah vparlah commented Jul 17, 2024

Proposed changes

Fix for this PR: (@wdio/appium-service): make Appium start on a random port #11757. The port value wasn't added in the appium start command. So, no matter what random port was chosen, appium always tries to start it on default, even if it's busy

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Jul 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@christian-bromann
Copy link
Copy Markdown
Member

@vparlah mind signing the CLA? Also it would be nice to harden this capability by having a proper unit test for this.

@vparlah vparlah force-pushed the appium-service/fix-random-port-v8 branch from f057b4f to 8f6fb5a Compare July 23, 2024 15:54
@vparlah
Copy link
Copy Markdown
Contributor Author

vparlah commented Jul 23, 2024

It doesn't seem like the failures are related to the changes in this PR, does it?

@christian-bromann
Copy link
Copy Markdown
Member

Nope they don't, we can ignore them.

Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants