Skip to content

fix(webdriver): better error response detection for Safari and FF#13150

Merged
christian-bromann merged 3 commits intomainfrom
cb/better-error-detection
Jul 27, 2024
Merged

fix(webdriver): better error response detection for Safari and FF#13150
christian-bromann merged 3 commits intomainfrom
cb/better-error-detection

Conversation

@christian-bromann
Copy link
Member

Proposed changes

I discovered that we don't properly elevate error messages from Safari and Firefox, e.g. no such alert due to the fact that we don't read the error responses correctly. This patch fixes that.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

I will backport this manually.

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jul 11, 2024
@christian-bromann christian-bromann force-pushed the cb/better-error-detection branch from 00231b9 to 372b1de Compare July 27, 2024 17:13
@christian-bromann christian-bromann merged commit 20e067c into main Jul 27, 2024
@christian-bromann christian-bromann deleted the cb/better-error-detection branch July 27, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant