Fix reloadSession subsequent commands#13084
Merged
christian-bromann merged 3 commits intowebdriverio:v8from Jul 4, 2024
Merged
Fix reloadSession subsequent commands#13084christian-bromann merged 3 commits intowebdriverio:v8from
christian-bromann merged 3 commits intowebdriverio:v8from
Conversation
414ae43 to
bbe62e5
Compare
Contributor
|
Hey ccharnkij 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Contributor
Author
|
@christian-bromann I'll do the same for main. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
A bit of an oversight when I worked on #12957. I found that, because the fields inside instance.options were not properly set at the end of the reloadSession function, creating a new session worked but any subsequent commands (like nagivate, etc.) did not work when any other connection fields aside from hostname and port, like protocol, were changed.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers