Skip to content

SDK-667 : Limit VCS info to 64kb v8#12932

Merged
christian-bromann merged 7 commits intowebdriverio:v8from
TamsilAmani:SDK-667-limit-vcs-to-64kb-v8
May 28, 2024
Merged

SDK-667 : Limit VCS info to 64kb v8#12932
christian-bromann merged 7 commits intowebdriverio:v8from
TamsilAmani:SDK-667-limit-vcs-to-64kb-v8

Conversation

@TamsilAmani
Copy link
Contributor

Proposed changes

Limiting the total size of VCS info to 64 Kb.

JIRA: https://browserstack.atlassian.net/browse/SDK-667

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 27, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann
Copy link
Member

@TamsilAmani mind signing the CLA?

@TamsilAmani
Copy link
Contributor Author

Signed the CLA @christian-bromann

@TamsilAmani TamsilAmani changed the title SDK-667 : Limit VCS info to 64kb SDK-667 : Limit VCS info to 64kb v8 May 28, 2024
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label May 28, 2024
@christian-bromann christian-bromann merged commit 305ccb7 into webdriverio:v8 May 28, 2024
@TamsilAmani TamsilAmani deleted the SDK-667-limit-vcs-to-64kb-v8 branch May 29, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants