[v8][browserstack-service]Add instrumentation for graceful kill builds#12916
Merged
christian-bromann merged 7 commits intowebdriverio:v8from May 23, 2024
Merged
[v8][browserstack-service]Add instrumentation for graceful kill builds#12916christian-bromann merged 7 commits intowebdriverio:v8from
christian-bromann merged 7 commits intowebdriverio:v8from
Conversation
christian-bromann
requested changes
May 22, 2024
| } | ||
| const data = { | ||
| 'stop_time': (new Date()).toISOString() | ||
| const data:any = { |
Member
There was a problem hiding this comment.
Why do we type this as any?
Contributor
Author
There was a problem hiding this comment.
added type, finished_metadata inside can be array of anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers