Skip to content

Dedupe Capabilities#12888

Merged
christian-bromann merged 3 commits intowebdriverio:v8from
EdmundasD:dedupe-capabilities
Jul 23, 2024
Merged

Dedupe Capabilities#12888
christian-bromann merged 3 commits intowebdriverio:v8from
EdmundasD:dedupe-capabilities

Conversation

@EdmundasD
Copy link
Copy Markdown
Contributor

@EdmundasD EdmundasD commented May 17, 2024

Proposed changes

This is an addition to #12430.

capabilities are also being duped when initializing WDIO via Launcher. Appears the dev decided not to include this change. More context here: #12430 (comment)

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented May 17, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: christian-bromann / name: Christian Bromann (661ab92)
  • ✅ login: EdmundasD / name: Edmundas Daunoras (7ff4d95, 80b13df)

@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented May 17, 2024

Thanks so much for raising the PR 👏 Some requests:

  • mind signing the CLA? Let me know if you have any questions
  • mind enhancing the unit test in packages/wdio-config/tests/node/configparser.test.ts?
  • mind raising the same PR for v8 so we can release it to the latest version?

@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented Jun 20, 2024

Any updates @EdmundasD ?

@EdmundasD
Copy link
Copy Markdown
Contributor Author

EdmundasD commented Jun 24, 2024

@christian-bromann, this was placed on my back burner as I was busy with other projects. When I was working on adding a unit test for this scenario, I was unable to get the duped capabilities to appear, so I'll look into this again this week and try to reproduce the issue within the unit test.

@EdmundasD
Copy link
Copy Markdown
Contributor Author

EdmundasD commented Jul 20, 2024

@christian-bromann, this is opened against v8 branch. Want me to open another one against main?

@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented Jul 22, 2024

this is opened against v8 branch. Want me to open another one against main?

Yes, let's do that!

@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented Jul 23, 2024

I will hold on, merging this until the main PR is raised. Thanks again.

@EdmundasD
Copy link
Copy Markdown
Contributor Author

EdmundasD commented Jul 23, 2024

Here is the main PR: #13211

christian-bromann
christian-bromann approved these changes Jul 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jul 23, 2024
@christian-bromann christian-bromann merged commit a5a5422 into webdriverio:v8 Jul 23, 2024
@wdio-bot
Copy link
Copy Markdown
Contributor

wdio-bot commented Jul 23, 2024

Hey EdmundasD 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@alex742 alex742 mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EdmundasD @christian-bromann @wdio-bot