Skip to content

fix: convert npm to pnpm in gitpod#12779

Merged
christian-bromann merged 5 commits intowebdriverio:mainfrom
sangcnguyen:main
May 3, 2024
Merged

fix: convert npm to pnpm in gitpod#12779
christian-bromann merged 5 commits intowebdriverio:mainfrom
sangcnguyen:main

Conversation

@sangcnguyen
Copy link
Contributor

@sangcnguyen sangcnguyen commented May 3, 2024

Proposed changes

This change addresses issue #12707. Additionally, I’ve removed the command line for navigating to the coverage folder, which appears to be missing.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@christian-bromann christian-bromann added the PR: Internal 🏠 PRs that contain changes internals label May 3, 2024
@christian-bromann christian-bromann merged commit 8652c2f into webdriverio:main May 3, 2024
@wdio-bot
Copy link
Contributor

wdio-bot commented May 3, 2024

Hey sangcnguyen 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expensable $15 💸 PR: Internal 🏠 PRs that contain changes internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants