Add Selenium downloadFile command#12778
Merged
christian-bromann merged 1 commit intowebdriverio:v8from May 23, 2024
Merged
Conversation
06f273f to
254ccc6
Compare
Member
|
Thanks for raising the PR!
Yes please! |
254ccc6 to
b8d2242
Compare
Contributor
Author
|
@christian-bromann I've made the changes you suggested. Please check again. For Safari, it doesn't seem like this feature is available. I've tried to setup local grid on my mac and noticed that Safari didn't have the download capability like the other 3 browsers. |
3a0d47b to
72ad429
Compare
Contributor
Author
|
@christian-bromann better? |
Member
|
Mind providing the same PR for the |
11 tasks
Member
|
@ccharnkij mind rebasing the branch? |
8ade7a3 to
0147540
Compare
Member
|
Thanks again for helping us backport this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds all 3 of Selenium Grid download command. For downloadFile, the logic is pretty much straight from Selenium JS binding
Types of changes
Checklist
Further comments
If needed and this is good, I can make the same change for main as well.
#12671
Reviewers: @webdriverio/project-committers