Skip to content

Add Selenium downloadFile command#12778

Merged
christian-bromann merged 1 commit intowebdriverio:v8from
ccharnkij:selenium-downloadfile
May 23, 2024
Merged

Add Selenium downloadFile command#12778
christian-bromann merged 1 commit intowebdriverio:v8from
ccharnkij:selenium-downloadfile

Conversation

@ccharnkij
Copy link
Copy Markdown
Contributor

Proposed changes

This change adds all 3 of Selenium Grid download command. For downloadFile, the logic is pretty much straight from Selenium JS binding

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

If needed and this is good, I can make the same change for main as well.

#12671

Reviewers: @webdriverio/project-committers

@ccharnkij ccharnkij force-pushed the selenium-downloadfile branch from 06f273f to 254ccc6 Compare May 2, 2024 03:57
@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented May 2, 2024

Thanks for raising the PR!

If needed and this is good, I can make the same change for main as well.

Yes please!

Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments

@ccharnkij ccharnkij force-pushed the selenium-downloadfile branch from 254ccc6 to b8d2242 Compare May 2, 2024 23:38
@ccharnkij
Copy link
Copy Markdown
Contributor Author

@christian-bromann I've made the changes you suggested. Please check again. For Safari, it doesn't seem like this feature is available. I've tried to setup local grid on my mac and noticed that Safari didn't have the download capability like the other 3 browsers.

Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments.

@ccharnkij ccharnkij force-pushed the selenium-downloadfile branch from 3a0d47b to 72ad429 Compare May 3, 2024 19:51
@ccharnkij
Copy link
Copy Markdown
Contributor Author

ccharnkij commented May 3, 2024

@christian-bromann better?

Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann
Copy link
Copy Markdown
Member

Mind providing the same PR for the main branch?

@ccharnkij ccharnkij mentioned this pull request May 23, 2024
11 tasks
@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label May 23, 2024
@christian-bromann
Copy link
Copy Markdown
Member

@ccharnkij mind rebasing the branch?

@ccharnkij ccharnkij force-pushed the selenium-downloadfile branch from 8ade7a3 to 0147540 Compare May 23, 2024 17:11
@christian-bromann christian-bromann merged commit 4da9867 into webdriverio:v8 May 23, 2024
@christian-bromann
Copy link
Copy Markdown
Member

Thanks again for helping us backport this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: New Feature 🚀 PRs that contain new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants