feat: replace `ts-node` with `tsx`, remove autoCompileOpts by goosewobbler · Pull Request #12752 · webdriverio/webdriverio

goosewobbler · 2024-04-25T21:24:19Z

Proposed changes

Removing ts-node and replacing it with tsx.

This also removes autoCompileOpts from the wdio configuration, replacing it with a tsConfigPath option for providing a custom tsconfig.

Closes #11878

TODO:

ESM loader syntax switching based on node version
Tests
Manual test CLI setup
Docs

Types of changes

Polish (an improvement for an existing feature)
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (improvements to the project's docs)
Specification changes (updates to WebDriver command specifications)
Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation (if appropriate)

Backport Request

This change is solely for v9 and doesn't need to be back-ported
Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

christian-bromann

Thanks so much for taking a stab at this. I have two questions based on the changes. Let me know when I can make a full review.

packages/wdio-cli/src/utils.ts

goosewobbler · 2024-04-27T11:52:25Z

Getting there, close to looking at docs. I'm not sure what to do about this ts-node reference in wdio-cucumber-framework, is this requireModule just to be left in there and add a tsx example into the comment?

christian-bromann · 2024-04-28T20:13:59Z

@goosewobbler the user doesn't really need this option since WebdriverIO takes care of compiling any TypeScript code. Feel free to just leave as is.

goosewobbler · 2024-04-29T11:00:39Z

I took a stab at the docs -- presumably the i18n files need to be updated too.

christian-bromann · 2024-04-29T17:11:05Z

presumably the i18n files need to be updated too.

Don't worry about these, we do this through a different platform.

goosewobbler · 2024-04-29T19:48:47Z

Still some more to do here, I tried to run some tests locally and the ConfigParser is failing to handle the TS file...

EDIT: found the culprit, we're exclusively using the ESM loader for tsx.

christian-bromann

Can we also update the TypeScript docs: https://webdriver.io/docs/typescript ?

packages/wdio-cli/src/commands/run.ts

christian-bromann · 2024-05-03T15:43:39Z

I will hopefully be able to take a close look over the weekend.

christian-bromann

Amazing work 🎉

packages/wdio-local-runner/src/worker.ts

wdio-bot · 2024-05-08T00:35:45Z

Hey goosewobbler 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

0xbuidler · 2024-08-08T19:29:32Z

Hey @christian-bromann has this been released in prod ? I cannot find tsConfigPath in Options.Testrunner ?

goosewobbler · 2024-08-09T01:23:26Z

@sshmaxime it's in v9 which hasn't been released yet. You can try pre-release builds by using the next tag instead of latest.

christian-bromann · 2024-08-09T03:06:15Z

Our v9 release is planned for August 15th.

0xbuidler · 2024-08-09T07:57:29Z

Ohhh sweet ! Thanks 🙏

goosewobbler added 3 commits April 25, 2024 22:03

feat: replace ts-node with tsx, remove autoCompileOpts

2016d9b

Merge remote-tracking branch 'origin/main' into sm/replace-ts-node

9bbce90

chore: update lockfile

70e1271

goosewobbler force-pushed the sm/replace-ts-node branch from 9e52168 to 70e1271 Compare April 25, 2024 21:37

goosewobbler added 5 commits April 25, 2024 22:45

fix: remove autoCompileOpts munging

09b7c99

chore: remove comment pertaining to ts-node

03fdd21

refactor: remove unused

1dacafd

test: fix windows path

ba969d1

refactor: rename tsxTsconfigPath to tsConfigPath

cf983ef

goosewobbler force-pushed the sm/replace-ts-node branch from 58c4c8d to cf983ef Compare April 25, 2024 23:14

goosewobbler mentioned this pull request Apr 25, 2024

Start electron without a binary (i.e. electron main.js) webdriverio-community/wdio-electron-service#331

Closed

christian-bromann reviewed Apr 25, 2024

View reviewed changes

packages/wdio-cli/src/utils.ts Show resolved Hide resolved

packages/wdio-cli/src/utils.ts Show resolved Hide resolved

feat: add loader flag switching to support lower node versions

75690c3

goosewobbler force-pushed the sm/replace-ts-node branch from 21bee3f to 75690c3 Compare April 26, 2024 10:49

goosewobbler and others added 5 commits April 26, 2024 12:20

fix: reinstate setupTypescript

4ecebb7

Merge branch 'main' into sm/replace-ts-node

1083f74

fix: replace ts-node ref

ecd44f2

refactor: remove unused module mocking

db0d345

refactor: remove unused @ts-expect-error

8c3269e

docs: update for tsx

05035dc

Merge branch 'main' into sm/replace-ts-node

5fa0c42

goosewobbler marked this pull request as ready for review April 29, 2024 18:04

goosewobbler marked this pull request as draft April 29, 2024 19:46

fix: ts-node log reference

ff22eff

goosewobbler force-pushed the sm/replace-ts-node branch from 69fcd76 to e445f11 Compare April 29, 2024 21:20

fix: use tsx instead of tsx/esm

db90bd8

goosewobbler force-pushed the sm/replace-ts-node branch from e445f11 to db90bd8 Compare April 29, 2024 21:26

goosewobbler marked this pull request as ready for review April 29, 2024 21:46

goosewobbler mentioned this pull request Apr 30, 2024

(feat): add appEntryPoint for executing electron directly with a main script webdriverio-community/wdio-electron-service#545

Closed

2 tasks

christian-bromann reviewed Apr 30, 2024

View reviewed changes

packages/wdio-cli/src/commands/run.ts Outdated Show resolved Hide resolved

goosewobbler added 2 commits May 2, 2024 01:26

fix: accept TSCONFIG_PATH env var alongside TSX_TSCONFIG_PATH

5d44e61

docs: update for TSCONFIG_PATH

95e8e85

goosewobbler requested a review from christian-bromann May 2, 2024 00:36

christian-bromann self-assigned this May 2, 2024

Merge branch 'main' into sm/replace-ts-node

89929cc

christian-bromann added the v9 label May 8, 2024

christian-bromann added this to the v9 milestone May 8, 2024

christian-bromann approved these changes May 8, 2024

View reviewed changes

packages/wdio-local-runner/src/worker.ts Outdated Show resolved Hide resolved

packages/wdio-local-runner/src/worker.ts Outdated Show resolved Hide resolved

christian-bromann added 2 commits May 7, 2024 17:25

Update packages/wdio-local-runner/src/worker.ts

b21811c

Update packages/wdio-local-runner/src/worker.ts

54b96f3

christian-bromann merged commit 963ddb9 into webdriverio:main May 8, 2024

christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label May 8, 2024

wdio-bot added the Expensable $150 💸 label May 8, 2024

torokati44 mentioned this pull request Aug 16, 2024

build(deps): bump ws, @wdio/browserstack-service, @wdio/cli, @wdio/local-runner and webdriverio in /web ruffle-rs/ruffle#17533

Closed

gavvvr mentioned this pull request Oct 22, 2024

[🐛 Bug]: non-typescript wdio setup fails to run without tsx #13787

Closed

3 tasks

Uh oh!

Conversation

goosewobbler commented Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Types of changes

Checklist

Backport Request

Further comments

Reviewers: @webdriverio/project-committers

Uh oh!

christian-bromann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

goosewobbler commented Apr 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christian-bromann commented Apr 28, 2024

Uh oh!

goosewobbler commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christian-bromann commented Apr 29, 2024

Uh oh!

goosewobbler commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christian-bromann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

christian-bromann commented May 3, 2024

Uh oh!

christian-bromann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wdio-bot commented May 8, 2024

Uh oh!

0xbuidler commented Aug 8, 2024

Uh oh!

goosewobbler commented Aug 9, 2024

Uh oh!

christian-bromann commented Aug 9, 2024

Uh oh!

0xbuidler commented Aug 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

goosewobbler commented Apr 25, 2024 •

edited

Loading

goosewobbler commented Apr 27, 2024 •

edited

Loading

goosewobbler commented Apr 29, 2024 •

edited

Loading

goosewobbler commented Apr 29, 2024 •

edited

Loading