Skip to content

Fix error messages#12665

Merged
christian-bromann merged 5 commits intowebdriverio:v8from
07souravkunda:fix_error_messages
Apr 15, 2024
Merged

Fix error messages#12665
christian-bromann merged 5 commits intowebdriverio:v8from
07souravkunda:fix_error_messages

Conversation

@07souravkunda
Copy link
Contributor

Proposed changes

  • Handle error message where user has no product access
  • Add retry for batch and stop requests
  • Send funnel data before clearing logs, so that we have the data reg. funnel data in logs

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Can we have a similar PR for the main branch?

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 10, 2024
@07souravkunda
Copy link
Contributor Author

@christian-bromann created PR for main.

@christian-bromann christian-bromann merged commit ac9b872 into webdriverio:v8 Apr 15, 2024
JohnJoser3 pushed a commit to JohnJoser3/webdriverio-browserstack-docs that referenced this pull request May 3, 2024
* add enable check, retry, message check

* empty commit to trigger tests

* added error handler for console logs patch

* chore: use isTrue

---------

Co-authored-by: Sriteja Sugoor <sritejakittu777@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants