(webdriverio): fix scope management for nested calls in browser runner#12497
Merged
christian-bromann merged 1 commit intov8from Mar 16, 2024
Merged
(webdriverio): fix scope management for nested calls in browser runner#12497christian-bromann merged 1 commit intov8from
christian-bromann merged 1 commit intov8from
Conversation
seanpoulter
approved these changes
Mar 16, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This patch improves how we regenerate elements from the browser runner in the Node.js context. It fixes a bug where elements could not be refetched when doing nested calls like this:
Types of changes
Checklist
Backport Request
I will raise a PR to the
mainbranch separately.Further comments
n/a
Reviewers: @webdriverio/project-committers