Skip to content

(webdriverio): fix scope management for nested calls in browser runner#12497

Merged
christian-bromann merged 1 commit intov8from
cb/better-parents
Mar 16, 2024
Merged

(webdriverio): fix scope management for nested calls in browser runner#12497
christian-bromann merged 1 commit intov8from
cb/better-parents

Conversation

@christian-bromann
Copy link
Member

Proposed changes

This patch improves how we regenerate elements from the browser runner in the Node.js context. It fixes a bug where elements could not be refetched when doing nested calls like this:

await expect($('.second').$$('li')).toBeElementsArrayOfSize(5)

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

I will raise a PR to the main branch separately.

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants