Fix appium service caps for multiremote#12455
Fix appium service caps for multiremote#12455christian-bromann merged 1 commit intowebdriverio:v8from
Conversation
christian-bromann
left a comment
There was a problem hiding this comment.
Thanks for taking a stab at this. Can we have a unit test for this please?
fa7b8be to
4913d0c
Compare
|
@christian-bromann Sure thing. |
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
One more ask, mind raising a PR for main as well?
|
You got it. |
|
Thanks! |
|
Hey ccharnkij 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Proposed changes
Fixed for #12382
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXQuestion for this. Do you need me to make another PR for main branch too?
Further comments
Reviewers: @webdriverio/project-committers