Skip to content

Fix appium service caps for multiremote#12455

Merged
christian-bromann merged 1 commit intowebdriverio:v8from
ccharnkij:appium-cap-multiremote
Mar 11, 2024
Merged

Fix appium service caps for multiremote#12455
christian-bromann merged 1 commit intowebdriverio:v8from
ccharnkij:appium-cap-multiremote

Conversation

@ccharnkij
Copy link
Contributor

@ccharnkij ccharnkij commented Mar 10, 2024

Proposed changes

Fixed for #12382

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Question for this. Do you need me to make another PR for main branch too?

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this. Can we have a unit test for this please?

@ccharnkij ccharnkij force-pushed the appium-cap-multiremote branch from fa7b8be to 4913d0c Compare March 10, 2024 19:55
@ccharnkij
Copy link
Contributor Author

@christian-bromann Sure thing.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

One more ask, mind raising a PR for main as well?

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 10, 2024
@ccharnkij
Copy link
Contributor Author

You got it.

@christian-bromann
Copy link
Member

Thanks!

@christian-bromann christian-bromann merged commit 6f9c046 into webdriverio:v8 Mar 11, 2024
@wdio-bot
Copy link
Contributor

Hey ccharnkij 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants