Skip to content

Browserstack Accessibility stability#12391

Merged
christian-bromann merged 17 commits intowebdriverio:v8from
amaanbs:a11y_stability
Mar 11, 2024
Merged

Browserstack Accessibility stability#12391
christian-bromann merged 17 commits intowebdriverio:v8from
amaanbs:a11y_stability

Conversation

@amaanbs
Copy link
Contributor

@amaanbs amaanbs commented Mar 1, 2024

Proposed changes

This change is to perform a page scan for Browserstack Accessibility before every DOM changing command that is being run as part of a user's test. The commands being wrapped for this purpose belong to the Webdriverio Browser & Element class.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@07souravkunda
Copy link
Contributor

Approved internally by Browserstack

@amaanbs
Copy link
Contributor Author

amaanbs commented Mar 4, 2024

@christian-bromann Addressed the above comments. Please re-review.

@christian-bromann
Copy link
Member

@amaanbs the code looks good. Mind raising the same PR for main?

@07souravkunda
Copy link
Contributor

@christian-bromann Done, please check PR for main branch #12448

@07souravkunda
Copy link
Contributor

@christian-bromann PR for main branch is merged. Is this PR good to merge?

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Mar 11, 2024
@christian-bromann christian-bromann merged commit 913e173 into webdriverio:v8 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants