Browserstack Accessibility stability#12391
Merged
christian-bromann merged 17 commits intowebdriverio:v8from Mar 11, 2024
Merged
Browserstack Accessibility stability#12391christian-bromann merged 17 commits intowebdriverio:v8from
christian-bromann merged 17 commits intowebdriverio:v8from
Conversation
07souravkunda
approved these changes
Mar 1, 2024
Contributor
|
Approved internally by Browserstack |
christian-bromann
requested changes
Mar 1, 2024
packages/wdio-browserstack-service/src/accessibility-handler.ts
Outdated
Show resolved
Hide resolved
packages/wdio-browserstack-service/src/accessibility-handler.ts
Outdated
Show resolved
Hide resolved
packages/wdio-browserstack-service/src/accessibility-handler.ts
Outdated
Show resolved
Hide resolved
packages/wdio-browserstack-service/src/accessibility-handler.ts
Outdated
Show resolved
Hide resolved
A11y stability comments
Contributor
Author
|
@christian-bromann Addressed the above comments. Please re-review. |
packages/wdio-browserstack-service/src/accessibility-handler.ts
Outdated
Show resolved
Hide resolved
packages/wdio-browserstack-service/src/accessibility-handler.ts
Outdated
Show resolved
Hide resolved
packages/wdio-browserstack-service/src/scripts/accessibility-scripts.ts
Outdated
Show resolved
Hide resolved
chore: remove redundant try-catch
packages/wdio-browserstack-service/src/accessibility-handler.ts
Outdated
Show resolved
Hide resolved
packages/wdio-browserstack-service/src/accessibility-handler.ts
Outdated
Show resolved
Hide resolved
packages/wdio-browserstack-service/src/accessibility-handler.ts
Outdated
Show resolved
Hide resolved
Member
|
@amaanbs the code looks good. Mind raising the same PR for |
365fbb6 to
982cc12
Compare
Contributor
|
@christian-bromann Done, please check PR for main branch #12448 |
Contributor
|
@christian-bromann PR for main branch is merged. Is this PR good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change is to perform a page scan for Browserstack Accessibility before every DOM changing command that is being run as part of a user's test. The commands being wrapped for this purpose belong to the Webdriverio Browser & Element class.
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers