Skip to content

(wdio-config): expand and simplify the --multi-run feature#12372

Merged
christian-bromann merged 8 commits intowebdriverio:v8from
erwinheitzman:backport-expand-and-simplify-multi-run
Feb 29, 2024
Merged

(wdio-config): expand and simplify the --multi-run feature#12372
christian-bromann merged 8 commits intowebdriverio:v8from
erwinheitzman:backport-expand-and-simplify-multi-run

Conversation

@erwinheitzman
Copy link
Copy Markdown
Member

@erwinheitzman erwinheitzman commented Feb 26, 2024

Proposed changes

In order to fail early when using the --multi-run flag I changed the order from (example using --multi-run 3:
spec-1, spec-1, spec-1, spec-2, spec-2, spec-2
to
spec-1, spec-2, spec-1, spec-2, spec-1, spec-2

This way when a test fails, the build breaks earlier than using the previous order.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@erwinheitzman erwinheitzman added PR: New Feature 🚀 PRs that contain new features PR: Polish 💅 PRs that contain improvements on existing features and removed PR: New Feature 🚀 PRs that contain new features labels Feb 26, 2024
Copy link
Copy Markdown
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erwinheitzman

This looks good, but do we also know why we initially set the multiRun in combination with the --spec or --suite flag?

@erwinheitzman
Copy link
Copy Markdown
Member Author

erwinheitzman commented Feb 27, 2024

It was a suggestion made by @christian-bromann in the original PR #9926 because he thought that people might accidentally run all tests multiple times by accident. If you use the --multi-run flag you know you are rerunning your tests and if you don't specify anything, it will run everything. This is always the case so I don't see how it would suddenly be an issue when using this flag.

@erwinheitzman
Copy link
Copy Markdown
Member Author

erwinheitzman commented Feb 27, 2024

I'm also planning to rename --multi-run 5 to --repeat 5 as I think it is a bit clearer (and because it is similar to the linux repeat cli).

I will only do this for v9 as it would be a breaking change.

@erwinheitzman erwinheitzman added PR: Breaking Change 💥 PRs that contain breaking changes and removed PR: Polish 💅 PRs that contain improvements on existing features labels Feb 27, 2024
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last minor thing, after that LGTM 👍

@christian-bromann
Copy link
Copy Markdown
Member

erwinheitzman added PR: Breaking Change 💥 and removed PR: Polish 💅 labels 8 hours ago

I wonder if we should just mark this as polish as we never documented the order of re-execution. Wdyt?

@erwinheitzman
Copy link
Copy Markdown
Member Author

I think the chance of any impact is slim and also if there is an impact it's likely small as well. Of course it's guessing work but I think polish should be fine indeed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants