Skip to content

fix upload file in selenium 4#12141

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
lacell75:fixFileUpload
Feb 1, 2024
Merged

fix upload file in selenium 4#12141
christian-bromann merged 1 commit intowebdriverio:mainfrom
lacell75:fixFileUpload

Conversation

@lacell75
Copy link
Contributor

@lacell75 lacell75 commented Feb 1, 2024 •
edited
Loading

Proposed changes

Fix upload file with selenium grid and standalone. Api path changed in selenium 4: https://github.com/SeleniumHQ/selenium/blob/selenium-4.17.0/javascript/node/selenium-webdriver/lib/http.js#L364

Related to Selenium#13534

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

christian-bromann
christian-bromann approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Feb 1, 2024
@christian-bromann christian-bromann merged commit 694ea75 into webdriverio:main Feb 1, 2024
@wdio-bot
Copy link
Contributor

wdio-bot commented Feb 1, 2024

Hey lacell75 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.
We've sent you an email with further instructions on how to claim your expenses from our development fund. Please
make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io
or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@lacell75 lacell75 mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lacell75 @wdio-bot @christian-bromann