Skip to content

(@wdio/browser-runner): improved stencil test integration#12140

Merged
christian-bromann merged 1 commit intomainfrom
cb/stencil-improvements
Feb 1, 2024
Merged

(@wdio/browser-runner): improved stencil test integration#12140
christian-bromann merged 1 commit intomainfrom
cb/stencil-improvements

Conversation

@christian-bromann
Copy link
Member

Proposed changes

Some improvements for browser runner and particular running Stencil tests:

  • make testStatePromise a scoped variable so we can run multiple tests per session
  • properly resolve Stencil config if in CJS mode
  • auto import h and Fragment
  • allow to keep components parameter of render method optional

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Feb 1, 2024
@christian-bromann christian-bromann merged commit f6a2625 into main Feb 1, 2024
@christian-bromann christian-bromann deleted the cb/stencil-improvements branch February 1, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant