Fix problem with tests which had been finished before the parent suite finished #12129
Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom Jan 30, 2024
Merged
Conversation
Contributor
|
Hey epszaw 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The problem happens, when cucumber feature suite ends before all scenarios and steps finished. In the Allure Report unfinished steps have
unknownstatus (original issue allure-framework/allure-js#826).The PR solves the problem and simplifies the code by reusing
_endTestmethod when we need to finish the current test or step.Before
After
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers