Skip to content

(@wdio/browser-runner): improved stencil test integration#12093

Merged
christian-bromann merged 4 commits intomainfrom
cb/improved-stencil-testing
Jan 26, 2024
Merged

(@wdio/browser-runner): improved stencil test integration#12093
christian-bromann merged 4 commits intomainfrom
cb/improved-stencil-testing

Conversation

@christian-bromann
Copy link
Member

Proposed changes

The original implementation wasn't ideal but did the job. This PR improves the Stencil integration by:

  • supporting project tsconfig.json options
  • better detection on whether a file needs to be transformed by looking for a Component import
  • auto-import of h and Fragment functions if missing
  • less string replacement of compiled code, we now transform with better options and only need to add the styles setter due to a bug in Stencil

Types of changes

  • Polish (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jan 26, 2024
@christian-bromann christian-bromann merged commit 42010d1 into main Jan 26, 2024
@christian-bromann christian-bromann deleted the cb/improved-stencil-testing branch January 26, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant