Skip to content

(@wdio/spec-reporter): introduce color option to disable colors for spec reporter#12092

Merged
christian-bromann merged 6 commits intowebdriverio:mainfrom
M-Hammad-Faisal:idea/disable-colored-output-wdio-spec-reporter
Feb 2, 2024
Merged

(@wdio/spec-reporter): introduce color option to disable colors for spec reporter#12092
christian-bromann merged 6 commits intowebdriverio:mainfrom
M-Hammad-Faisal:idea/disable-colored-output-wdio-spec-reporter

Conversation

@M-Hammad-Faisal
Copy link
Contributor

@M-Hammad-Faisal M-Hammad-Faisal commented Jan 25, 2024 •
edited
Loading

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

  • color attribute added to wdio spec reporter which enabled/disable coloring of logs in terminal.

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 25, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

christian-bromann
christian-bromann reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend for this to create a unit test and verify if a custom chalk instance was created with the right parameters

christian-bromann
christian-bromann reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment:

@M-Hammad-Faisal
enums added and snapshot updated
2300082 
- ChalkColor and State enum added
- snapshot updated
- code is refactored accordingly
christian-bromann
christian-bromann reviewed Jan 29, 2024
View reviewed changes
@M-Hammad-Faisal
Copy link
Contributor Author

M-Hammad-Faisal commented Feb 2, 2024 •
edited
Loading

@christian-bromann can you tell me why is one check still failing? am i missing someting? its e2e/mac one.

christian-bromann
christian-bromann approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks a lot!

Congratulations on your first WebdriverIO contribution! 🎉

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Feb 2, 2024
@christian-bromann christian-bromann changed the title disable colored output in @wdio/spec-reporter (@wdio/spec-reporter): introduce color option to disable colors for spec reporter Feb 2, 2024
@christian-bromann christian-bromann merged commit 0bd4db5 into webdriverio:main Feb 2, 2024
@wdio-bot
Copy link
Contributor

wdio-bot commented Feb 2, 2024

Hey M-Hammad-Faisal 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.
We've sent you an email with further instructions on how to claim your expenses from our development fund. Please
make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io
or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $50 💸 PR: New Feature 🚀 PRs that contain new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@M-Hammad-Faisal @wdio-bot @christian-bromann