Skip to content

Feat: Add free text search to '--exclude' param#12077

Merged
christian-bromann merged 7 commits intowebdriverio:mainfrom
tech-dm-klymenko:dmklymenko-feat-add_free_search_to_exclude_param
Jan 30, 2024
Merged

Feat: Add free text search to '--exclude' param#12077
christian-bromann merged 7 commits intowebdriverio:mainfrom
tech-dm-klymenko:dmklymenko-feat-add_free_search_to_exclude_param

Conversation

@tech-dm-klymenko
Copy link
Contributor

@tech-dm-klymenko tech-dm-klymenko commented Jan 23, 2024 •
edited
Loading

Feature for #8210

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Jan 23, 2024
@christian-bromann christian-bromann self-requested a review January 23, 2024 16:36
christian-bromann
christian-bromann reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset looks good 👍 do you think we can add some smoke tests? We should already have some for applying keyword spec params.

Thanks a lot!

@tech-dm-klymenko
Copy link
Contributor Author

tech-dm-klymenko commented Jan 23, 2024

@christian-bromann
Sure! I will cover this functionality with smoke tests

@tech-dm-klymenko
Copy link
Contributor Author

tech-dm-klymenko commented Jan 30, 2024

@christian-bromann
I have added smoke tests and updated documentation accordingly.
Please review

christian-bromann
christian-bromann approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optimization but otherwise LGTM 👍

christian-bromann
christian-bromann reviewed Jan 30, 2024
View reviewed changes
@christian-bromann christian-bromann merged commit e8aae21 into webdriverio:main Jan 30, 2024
@wdio-bot
Copy link
Contributor

wdio-bot commented Jan 30, 2024

Hey tech-dm-klymenko 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.
We've sent you an email with further instructions on how to claim your expenses from our development fund. Please
make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io
or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@Delta456 Delta456 mentioned this pull request Oct 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $100 💸 PR: New Feature 🚀 PRs that contain new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tech-dm-klymenko @wdio-bot @christian-bromann