Skip to content

Added default name for tms link to be displayed in allure reports#12076

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
AndreiSakalouski:fix/allure-link-name
Jan 23, 2024
Merged

Added default name for tms link to be displayed in allure reports#12076
christian-bromann merged 1 commit intowebdriverio:mainfrom
AndreiSakalouski:fix/allure-link-name

Conversation

@AndreiSakalouski
Copy link
Contributor

@AndreiSakalouski AndreiSakalouski commented Jan 23, 2024

Proposed changes

Fixes: https://github.com/webdriverio/webdriverio/issues/12070

Jenkins Allure plugin doesn't display tms link because wdio allure plugin creates tms link without a default name parameter. I added the default name for tms link.

Types of changes

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • [x ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 23, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: AndreiSakalouski / name: Andrei Sakalouski (8f026dd)

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 23, 2024
christian-bromann
christian-bromann approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍

@christian-bromann christian-bromann merged commit b482545 into webdriverio:main Jan 23, 2024
@christian-bromann christian-bromann added the First Contribution 🎉 Highlights PRs of people that made their first contribution to the project label Jan 23, 2024
@AndreiSakalouskiSalesfloor AndreiSakalouskiSalesfloor mentioned this pull request Jan 25, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

First Contribution 🎉 Highlights PRs of people that made their first contribution to the project PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndreiSakalouski @christian-bromann