(@wdio/browser-runner): improve performance by less pulling#12041
Merged
christian-bromann merged 2 commits intomainfrom Jan 18, 2024
Merged
(@wdio/browser-runner): improve performance by less pulling#12041christian-bromann merged 2 commits intomainfrom
christian-bromann merged 2 commits intomainfrom
Conversation
ilhamaditya
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some performance improvements in the browser runner. We are using now the new messaging system to push the result to the worker rather than pulling it from a browser global through
executecommand.Background: it seemed that with a lot of test the execute command always returned the same result e.g.
failures = nullwhich would cause the test to stale and timeout.Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers