Skip to content

(@wdio/browser-runner): improve performance by less pulling#12041

Merged
christian-bromann merged 2 commits intomainfrom
cb/browser-runner-performance
Jan 18, 2024
Merged

(@wdio/browser-runner): improve performance by less pulling#12041
christian-bromann merged 2 commits intomainfrom
cb/browser-runner-performance

Conversation

@christian-bromann
Copy link
Member

Proposed changes

Some performance improvements in the browser runner. We are using now the new messaging system to push the result to the worker rather than pulling it from a browser global through execute command.

Background: it seemed that with a lot of test the execute command always returned the same result e.g. failures = null which would cause the test to stale and timeout.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 18, 2024
@christian-bromann christian-bromann merged commit e4a2510 into main Jan 18, 2024
@christian-bromann christian-bromann deleted the cb/browser-runner-performance branch January 18, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants