Skip to content

[browserstack-service] Fix integrations data#12034

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
sriteja777:fix_integrations_data
Jan 17, 2024
Merged

[browserstack-service] Fix integrations data#12034
christian-bromann merged 2 commits intowebdriverio:mainfrom
sriteja777:fix_integrations_data

Conversation

@sriteja777
Copy link
Contributor

@sriteja777 sriteja777 commented Jan 17, 2024 •
edited
Loading

Proposed changes

  • Add caps params to Insights handler

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@sriteja777
Copy link
Contributor Author

sriteja777 commented Jan 17, 2024

Hey @christian-bromann, the tests are failing on this PR, but seems unrelated to the changes in this PR (also tried rerunning). Can you please check once?

@karanshah-browserstack
Copy link

karanshah-browserstack commented Jan 17, 2024

Hello @christian-bromann,
Due to a merge conflict problem, we accidentally broke a feature for one of the BrowserStack products in the most recent version of wdio v8.28.0. We are doing an internal root cause analysis for the problem, as well as determining how to prevent it in the future.
For the time being, we need your assistance in reviewing from the wdio perspective and releasing a bug fix for the wdio-browserstack service.

christian-bromann
christian-bromann approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 17, 2024
@christian-bromann christian-bromann merged commit 394092c into webdriverio:main Jan 17, 2024
@amaanbs amaanbs mentioned this pull request Mar 6, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

+1 more reviewer

@karanshah-browserstack karanshah-browserstack karanshah-browserstack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sriteja777 @karanshah-browserstack @christian-bromann