Skip to content

Sauce us east 4#11982

Merged
christian-bromann merged 5 commits intowebdriverio:mainfrom
nullp2ike:sauce-us-east-4
Jan 11, 2024
Merged

Sauce us east 4#11982
christian-bromann merged 5 commits intowebdriverio:mainfrom
nullp2ike:sauce-us-east-4

Conversation

@nullp2ike
Copy link
Contributor

@nullp2ike nullp2ike commented Jan 9, 2024 •
edited
Loading

Proposed changes

Adding support for new Saucelabs US East 4 DC

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 9, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

christian-bromann
christian-bromann approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

christian-bromann
christian-bromann reviewed Jan 10, 2024
View reviewed changes
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jan 11, 2024
@christian-bromann christian-bromann merged commit f519788 into webdriverio:main Jan 11, 2024
@christian-bromann christian-bromann added First Contribution 🎉 Highlights PRs of people that made their first contribution to the project and removed First Contribution 🎉 Highlights PRs of people that made their first contribution to the project labels Jan 11, 2024
@christian-bromann
Copy link
Member

christian-bromann commented Jan 11, 2024

Congratulations on your first contribution to WebdriverIO 🎉

This project thrives on the invaluable involvement of our community, and we are
truly grateful for your contribution. We eagerly anticipate witnessing more of
your exceptional work, so please don't hesitate to inform us if we can assist
you in identifying intriguing areas where you can make further contributions.

Join our lively Discord channel and reach out to us;
we would be delighted to connect with you. Your efforts are deeply appreciated,
and we extend our heartfelt gratitude to you. 🙏 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

First Contribution 🎉 Highlights PRs of people that made their first contribution to the project PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nullp2ike @christian-bromann