Fix #11684: Improve AfterTest() for Jasmine#11957
Fix #11684: Improve AfterTest() for Jasmine#11957christian-bromann merged 13 commits intowebdriverio:mainfrom
Conversation
christian-bromann
left a comment
There was a problem hiding this comment.
Some comments, great progress!
|
And yet another unexpected moment came to light. Even if the tests are passed, the variable result = await executeAsync.call(this, specFn, retries, specFnArgs, timeout) |
christian-bromann
left a comment
There was a problem hiding this comment.
@tech-dm-klymenko last request: can we add a smoke test for this to ensure we don't regress in the future. I would recommend to create a new smoke test suite that runs a single (failing) jasmine test and writes the result of the afterTest hook into a file to then verify the result again in the smoke test. Let me know if you have any questions.
|
@christian-bromann What do you think? |
christian-bromann
left a comment
There was a problem hiding this comment.
Amazing work, thanks so much 🙏
fyi: the build is currently failing due to an issue with the component tests, will move ahead and merge as everything before passed just fine.
Fix for #11684
Proposed changes
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers