Skip to content

(docs): add documentation on visual testing#11906

Merged
christian-bromann merged 31 commits intomainfrom
visual-testing-docs
Jan 11, 2024
Merged

(docs): add documentation on visual testing#11906
christian-bromann merged 31 commits intomainfrom
visual-testing-docs

Conversation

@wswebcreation
Copy link
Member

@wswebcreation wswebcreation commented Dec 20, 2023

Proposed changes

Adding Visual Docs based on https://github.com/wswebcreation/wdio-image-comparison-service

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

image

@christian-bromann christian-bromann marked this pull request as ready for review January 5, 2024 06:52
@christian-bromann
Copy link
Member

Reviewing this now.

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Jan 5, 2024
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a first look at it, mostly little wordings and formattings, the rest looks good. I wonder if pages the Methods and Options page should be moved to the API page, wdyt?

@wswebcreation
Copy link
Member Author

Took a first look at it, mostly little wordings and formattings, the rest looks good. I wonder if pages the Methods and Options page should be moved to the API page, wdyt?

I'm assuming you mean this page, but I would like to keep it within the "scope" of the Visual docs itself.

christian-bromann and others added 22 commits January 10, 2024 19:22
- check images will follow
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
@christian-bromann
Copy link
Member

Enhanced docs with visual matcher:
Screenshot 2024-01-10 at 7 44 29 PM

@christian-bromann christian-bromann merged commit c1e4117 into main Jan 11, 2024
@christian-bromann christian-bromann deleted the visual-testing-docs branch January 11, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Docs 📝 PRs that contain changes to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants