Skip to content

refactor: Hide exception logs for logs upload in test observability#11903

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
sauravdas1997:observability-logLevel
Dec 21, 2023
Merged

refactor: Hide exception logs for logs upload in test observability#11903
christian-bromann merged 2 commits intowebdriverio:mainfrom
sauravdas1997:observability-logLevel

Conversation

@sauravdas1997
Copy link
Contributor

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@karanshah-browserstack
Copy link

@christian-bromann Did you get a chance to review this? Looks good from our side.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Dec 21, 2023
@christian-bromann christian-bromann merged commit 3297741 into webdriverio:main Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants