docs: update autowait limitations example#11828
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Dec 8, 2023
Merged
docs: update autowait limitations example#11828christian-bromann merged 1 commit intowebdriverio:mainfrom
christian-bromann merged 1 commit intowebdriverio:mainfrom
Conversation
update the numeric index used in the last javascript example on the page to access the array with index 1. the conditional above it returns `false` if the length of the array is not 2. accessing an array at `elms[2]` on a non-sparse array may not be possible in this situation. I then worked backwards to the previous example, updated the array access there too for continuity.
christian-bromann
approved these changes
Dec 8, 2023
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Great 👁️ for detail 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
update the numeric index used in the last javascript example on the page to access the array with index 1. the conditional above it returns
falseif the length of the array is not 2. accessing an array atelms[2]on a non-sparse array may not be possible in this situation.I then worked backwards to the previous example, updated the array access there too for continuity.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers