(@wdio/jasmine-framework): attach asymmetric matchers to expect object#11820
Merged
erwinheitzman merged 2 commits intomainfrom Dec 6, 2023
Merged
(@wdio/jasmine-framework): attach asymmetric matchers to expect object#11820erwinheitzman merged 2 commits intomainfrom
erwinheitzman merged 2 commits intomainfrom
Conversation
19697d0 to
c9a3908
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Asymmetric matchers are registered to the
jasminenamespace in Jasmine, see https://jasmine.github.io/api/edge/jasmine.html#.any. However in our docs we often the ones attached toexpectdirectly which is how theexpectlib is doing it.This patch makes both ways work in Jasmine.
fixes #11817
Types of changes
Checklist
Further comments
n/a
Reviewers: @webdriverio/project-committers