(@wdio/appium-service): make Appium start on a random port#11757
Merged
christian-bromann merged 2 commits intomainfrom Nov 28, 2023
Merged
(@wdio/appium-service): make Appium start on a random port#11757christian-bromann merged 2 commits intomainfrom
christian-bromann merged 2 commits intomainfrom
Conversation
vparlah
reviewed
Jul 17, 2024
Comment on lines
+132
to
+138
| /** | ||
| * Get port from service option or use a random port | ||
| */ | ||
| const port = typeof this._args.port === 'number' | ||
| ? this._args.port | ||
| : await getPort({ port: DEFAULT_APPIUM_PORT }) | ||
| this._setCapabilities(port) |
Contributor
There was a problem hiding this comment.
@christian-bromann it feels like you missed adding the new port value to the _appiumCliArgs arr...
this._appiumCliArgs.push(...formatCliArgs({ port }))
Without the line above, it tries to start the appium on port 4723, even logs say different port value...
Member
Author
There was a problem hiding this comment.
Mind raising a PR with a fix?
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This patch makes the Appium service start on a random port instead of always the same default port. This makes using the service a bit simpler as the user might have other Appium processes running unrelated to their test run with the service.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers