Skip to content

chore: Fix build and test timeouts#11756

Merged
christian-bromann merged 5 commits intowebdriverio:mainfrom
sauravdas1997:browserstack-timeout-handling
Nov 29, 2023
Merged

chore: Fix build and test timeouts#11756
christian-bromann merged 5 commits intowebdriverio:mainfrom
sauravdas1997:browserstack-timeout-handling

Conversation

@sauravdas1997
Copy link
Contributor

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 28, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@christian-bromann
Copy link
Member

@sauravdas1997 mind signing the CLA?

@sauravdas1997
Copy link
Contributor Author

Hey @christian-bromann Signing done, All comments resolved. Thanks

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Nov 29, 2023
@christian-bromann christian-bromann merged commit c623516 into webdriverio:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants