Skip to content

(@wdio/utils): don't throw if returning null#11752

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
HannaTarasevich:wdio.fixNull
Nov 27, 2023
Merged

(@wdio/utils): don't throw if returning null#11752
christian-bromann merged 1 commit intowebdriverio:mainfrom
HannaTarasevich:wdio.fixNull

Conversation

@HannaTarasevich
Copy link
Contributor

@HannaTarasevich HannaTarasevich commented Nov 27, 2023

Proposed changes

Fix #11751

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Nov 27, 2023
@christian-bromann christian-bromann merged commit 6b6f40e into webdriverio:main Nov 27, 2023
@christian-bromann
Copy link
Member

Released with v8.24.3. Congratulations on your first WebdriverIO contribution 🎉

@HannaTarasevich HannaTarasevich deleted the wdio.fixNull branch November 28, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: "Return null" leads to unexpected error

2 participants